On Thu, 8 Dec 2022 09:19:54 GMT, Per Minborg <pminb...@openjdk.org> wrote:

> This PR proposes adding hyperlinks to the sealed graphic layout making 
> navigation much simpler via the image.

Given that this feature is welcome, I would suggest changing the priority of 
the respective JBS issue to P3, withdrawing this PR and creating a new PR that 
targets openjdk/jdk20 after it has been created (which should be within hours 
from now).

make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 207:

> 205:             private static String relativeLink(TypeElement rootNode, 
> TypeElement node) {
> 206:                 var backNavigator = 
> rootNode.getQualifiedName().toString().chars()
> 207:                         .filter(c -> '.' == c)

"Yoda conditions" are usually frowned upon. Can `c` be `null`?

-------------

PR: https://git.openjdk.org/jdk/pull/11580

Reply via email to