On Thu, 8 Dec 2022 16:22:30 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 207: >> >>> 205: private static String relativeLink(TypeElement rootNode, >>> TypeElement node) { >>> 206: var backNavigator = >>> rootNode.getQualifiedName().toString().chars() >>> 207: .filter(c -> '.' == c) >> >> "Yoda conditions" are usually frowned upon. Can `c` be `null`? > > `c` is a character `c` is an `int`, but even that does not matter. I read off `==` but somehow pictured `equals` in my head; so, null-ness does not matter here at all. That said, unnecessary "Yoda conditions" should probably be avoided. ------------- PR: https://git.openjdk.org/jdk/pull/11580