On Mon, 12 Dec 2022 08:14:51 GMT, Robbin Ehn <r...@openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add comment explaining __ubsan_default_options and UBSAN_OPTIONS
>>   
>>   Signed-off-by: Justin King <jck...@google.com>
>
> src/java.base/share/native/launcher/main.c line 49:
> 
>> 47: #endif // UNDEFINED_BEHAVIOR_SANITIZER
>> 48: 
>> 49: /*
> 
> As I said we have more launcher than 'java', if you put this method here you 
> must put it in all launchers.
> I.e. all binaries that call JNI_CreateJavaVM, such our tests, e.g. 
> jni/daemonDestroy/TestDaemonDestroy.java

Attempting an approach that automatically includes `__ubsan_default_options` in 
binaries by "automagically" including a source file for anything using 
`SetupNativeCompilation` with `TYPE` being `EXECUTABLE`.

-------------

PR: https://git.openjdk.org/jdk/pull/11604

Reply via email to