On Tue, 13 Dec 2022 00:37:42 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Primarily, but its not a requirement. We should also be able to invoke >> `java` as is. The environment variables should be used to force specific >> behavior for a single invocation. Otherwise, if one forgets to pass the >> environment variables, things may not go as expected. > > It really comes down to who we expect to do these ubsan builds and how we > expect them to be used. If this is something explicit then using the env-var > seems fine to me. I'm not sure why it needs to be enabled by default through > this source modification. > > I'd like to hear other opinions on this. Sure. It should be noted that whatever we do here for default options will likely have to be repeated for LSan and ASan eventually. So it should be repeatable and easy to maintain. IMO we should enforce strict defaults and then let manual invocations make it less strict via environment variables. ------------- PR: https://git.openjdk.org/jdk/pull/11604
