On Fri, 23 Dec 2022 17:24:07 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options that still use AC_ARG_WITH in jdk-version.m4. >> They are out of the scope of this commit, which aims only to rework the >> previous integrated commits mentioned above. > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Login Shell v3 Finally got it to work. MSYS2 is unique in that the bash it provides cannot be safely called standalone like it can on all the other platforms. While I did figure this out relatively early, trying to use the actual msys launchers as the shells themselves made me almost vomit blood, and the Visual Studio installers also straight up crash when in a proper Unix environment (Thanks for nothing, Microsoft). I've instead just left the bash settings as-is for Windows and only set the shell as a login shell (What bash calls an instance of itself with all the proper environment setup) on the step that actually requires it, which is the configure step, and I _really_ hope I never have to touch it again ------------- PR: https://git.openjdk.org/jdk/pull/11020
