On Wed, 28 Dec 2022 10:44:41 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options that still use AC_ARG_WITH in jdk-version.m4. >> They are out of the scope of this commit, which aims only to rework the >> previous integrated commits mentioned above. > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 61 additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into util > - Merge remote-tracking branch 'upstream/master' into util > - Login Shell v3 > - Login Shell v2 > - Xleanup > - Login Shell > - Debug > - Fullpath > - Run > - Drop interactive flag > - ... and 51 more: https://git.openjdk.org/jdk/compare/d4a7ceb5...074bb9ae I'm not sure I understand the relationship of the GHA fix in this PR wrt #11782. Are both needed? Do 11782 supersede this fix? If both are needed, would it make sense to fold the GHA fix part of this PR into 11782? Otherwise, I'd like to ask you to move that part to a separate PR, so this one is just about the configure script changes, and integrate it prior to this. ------------- PR: https://git.openjdk.org/jdk/pull/11020
