On Tue, 3 Jan 2023 06:36:38 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Not pretty, but effective. > > Do we need some text added to the hotspot style guide to describe this usage? > Should we bracket all includes of system headers with these, or only those > known to cause a problem? Most of the uses are currently violations of the style guide (e.g. using the Standard Library (other than the C++ wrappers for standard C headers)). The only exception to that is the wrapper around the gtest header inclusions. So no, I don't think we need to do anything about this in the style guide. (My prototype / proposal for permitting more use of the Standard Library makes use of this same mechanism. The new helper files originated there, and this change lets me eliminate one of the commits in that work.) ------------- PR: https://git.openjdk.org/jdk/pull/11770
