> Please review this change to provide and use mechanisms for dealing with uses > of the standard assert macro (from <assert.h> or <cassert>) in 3rd party code > that we use in HotSpot. > > We provide a pair of utility header files, to be included before and after a > header that may use (and so include) the standard assert macro. These new > headers provide a scope in which the HotSpot assert macro is not defined, and > then reinstated after. > > We also define NDEBUG in release builds of HotSpot, so any uses of the > standard assert macro in such 3rd party code will be disabled. > > Finally, we use the new utility headers in some gtests and in our gtest > wrapper header (unittest.hpp), eliminating problems the gtest implementation > and with some versions of some standard libraries that the tests use. > > Testing: > mach5 tier1
Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into std-assert - define NDEBUG in HotSpot release builds - use vmassert_uninstall/reinstall in gtests - utility for manipulating HotSpot assert macro ------------- Changes: - all: https://git.openjdk.org/jdk/pull/11770/files - new: https://git.openjdk.org/jdk/pull/11770/files/8b9a2d60..c122a265 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11770&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11770&range=00-01 Stats: 5917 lines in 567 files changed: 2798 ins; 1954 del; 1165 mod Patch: https://git.openjdk.org/jdk/pull/11770.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11770/head:pull/11770 PR: https://git.openjdk.org/jdk/pull/11770
