On Wed, 4 Jan 2023 20:07:48 GMT, Matias Saavedra Silva <matsa...@openjdk.org> wrote:
> This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release when building the JDK repo. > > If it's able to connect to an artifactory that hosts valid JDK releases: > - Download and install previous JDK versions (19 through N) from the > artifactory > where N == java.lang.Runtime.version​().major() - 1 > - test the interaction of the current JDK versus each of the previous > releases. > > If it's not able to connect to such an artifactory, revert to the existing > logic in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 209: > 207: case "Windows": > 208: jdkArtifactMap.put("version", version); > 209: jdkArtifactMap.put("build_number", build); The above two lines can be shared across all oses. test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 256: > 254: } > 255: return osName; > 256: } Instead of writing your own code for detecting OS/architecture, etc, you should use [test/lib/jdk/test/lib/Platform.java ](https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/Platform.java) ------------- PR: https://git.openjdk.org/jdk/pull/11852
