On Wed, 4 Jan 2023 20:07:48 GMT, Matias Saavedra Silva <matsa...@openjdk.org> wrote:
> This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release when building the JDK repo. > > If it's able to acquire previous valid JDK releases: > - Download and install previous JDK versions (19 through N) > where N == java.lang.Runtime.version​().major() - 1 > - Test the interaction of the current JDK versus each of the previous > releases > > If it's not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. I can't really review this since I don't know this code but it seems like something that will timeout in the future if it's trying to download JDKs for this test. bin/jib.sh line 197: > 195: export REAL_CONFIGURE_COMMAND_EXEC_SHORT="$myname" > 196: > 197: ${installed_jib_script} "$@" Don't we need this? test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 80: > 78: > 79: // Earliest testable version is 19 > 80: int n = java.lang.Runtime.version().major() - 1; Can this just do n-1 and not download every release? So if JDK 20 works with JDK 19, then JDK 21 works with JDK 20 and transitively would work with 19? ------------- PR: https://git.openjdk.org/jdk/pull/11852
