On Fri, 16 Dec 2022 16:10:10 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify logic for including __ubsan_default_options >> >> Signed-off-by: Justin King <jck...@google.com> > > I much also check: is this really needed for *all* executables we make? I > would have guessed that it would suffice with the "launchers", i.e. like > `java`, `javac`, `jar` etc. These are all compiled from a single source file, > `src/java.base/share/native/launcher/main.c`, with different defines > depending on what Java classes it should actually launch, and with different > output names. > > Doing things this way will also affect non-launcher executables, like > `jabswitch`, `msiwrapper` and all executable test binaries. > > That might be correct, but I could not be certain of that from trying to read > the backlog of discussion in this bug. I think @magicus is back next week. Since this is mainly build stuff I'll sit this one out. ------------- PR: https://git.openjdk.org/jdk/pull/11604
