On Fri, 20 Jan 2023 22:24:32 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
> Please review this PR which updates the required version of googletest to > v1.13.0. > > It’s been (quite) a while since we upgraded the version of googletest used to > run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) > is from 2018 and there is build issue with Xcode 14.x which has been resolved > in more recent versions of googletest. > > The configure.ac file has been removed from googletest so the only file which > contains the version is CMakeLists.txt, hence the removed logic from > `make/autoconf/lib-tests.m4`. > > Testing: tier1, gtest:all, GHA Good to see we didn't need more changes in tests to make this work. doc/building.md line 873: > 871: > 872: * by downloading and unpacking the source bundle from > [here](https://github.com/google/googletest/releases/tag/v1.13.0) > 873: * or by checking out `v1.13.0` tag of `googletest` project: `git clone > -b v1.13.0 https://github.com/google/googletest` You need to generate the html file for these changes. `make update-build-docs` ------------- PR: https://git.openjdk.org/jdk/pull/12125
