On Sat, 21 Jan 2023 00:09:18 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
>> Please review this PR which updates the required version of googletest to >> v1.13.0. >> >> It’s been (quite) a while since we upgraded the version of googletest used >> to run the hotspot unit tests (test/hotspot/gtest). The current version >> (1.8.1) is from 2018 and there is build issue with Xcode 14.x which has been >> resolved in more recent versions of googletest. >> >> The configure.ac file has been removed from googletest so the only file >> which contains the version is CMakeLists.txt, hence the removed logic from >> `make/autoconf/lib-tests.m4`. >> >> Testing: tier1, gtest:all, GHA > > Mikael Vidstedt has updated the pull request incrementally with one > additional commit since the last revision: > > Update doc/building.html make/autoconf/lib-tests.m4 line 63: > 61: # Verify that the version is the required one. > 62: GTEST_VERSION_1="`$GREP GOOGLETEST_VERSION > $GTEST_FRAMEWORK_SRC/CMakeLists.txt | $SED -E -e 's/set\(GOOGLETEST_VERSION > (.*)\)/\1/'`" > 63: if test "x$GTEST_VERSION_1" != "x1.13.0"; then Can you extract this value as a "constant" and put it next to `JTREG_MINIMUM_VERSION` in the top of the file? (Also in the error message) ------------- PR: https://git.openjdk.org/jdk/pull/12125
