Re: RFR: 8302460: System C++ Compiler for cross compiling gcc is dangerously wrong

[Magnus Ihse Bursie]

On Tue, 14 Feb 2023 14:32:10 GMT, Julian Waters <jwat...@openjdk.org> wrote:

> Full details in linked entry, man did this give me a scare on my local branch
> 
> All C++ compilers for the build operating system are under the name c++ (when 
> selected compiler is gcc), but when searching for BUILD_CXX the compiler 
> given priority is an uppercase CC, and then g++, which is not correct since 
> this simply links to the C compiler instead

This do not affect macOS. The change is being made here:

if microsoft toolchain 
   ...
else 
   if macOS 
      ...
   else 
      .... <=== here
   endif
endif


So, in practice, it is for linux, but formally, everything that is not using 
the microsoft toolchain and is not running on macOS.

-------------

PR: https://git.openjdk.org/jdk/pull/12558