On Thu, 9 Feb 2023 14:05:10 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/internal/classfile/constantpool/MemberRefEntry.java > line 67: > >> 65: * {@return whether this member is an interface method} >> 66: */ >> 67: boolean isInterface(); > > I'd prefer to see this to `MethodRefEntry`. But again, there's an entry for > interface methods, so not sure how much this is needed. The same as above, it is possible to remove it and the two use cases (in `ConcreteMethodHandleEntry::asSymbol` and `ClassPrinterImpl`) replace with `instanceof InterfaceMethodRefEntry`. Thanks! ------------- PR: https://git.openjdk.org/jdk/pull/10982