On Thu, 9 Feb 2023 14:07:32 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/internal/classfile/constantpool/MethodHandleEntry.java
> line 40:
>
>> 38:
>> 39: /**
>> 40: * {@return the reference kind of this method handle}
>
> Where are the constants that can be used to decode the MH kind? Perhaps a
> reference from the javadoc could be helpful.
Fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/constantpool/PoolEntry.java
> line 55:
>
>> 53: * {@return the number of constant pool slots this entry consumes}
>> 54: */
>> 55: int poolEntries();
>
> maybe `width` ?
Yes, it sounds better. Fixed, thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
