On Wed, 1 Mar 2023 14:37:53 GMT, Rich DiCroce <d...@openjdk.org> wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing >> list. > > Rich DiCroce has updated the pull request incrementally with one additional > commit since the last revision: > > Changes as per review comments Network interface changes LGTM now. I'm not sure about the change to ResolverConfiguration, see below. src/java.base/windows/native/libnet/ResolverConfigurationImpl.c line 190: > 188: flags |= GAA_FLAG_SKIP_MULTICAST; > 189: flags |= GAA_FLAG_SKIP_FRIENDLY_NAME; > 190: flags |= GAA_FLAG_INCLUDE_ALL_INTERFACES; Is this needed? As far as I could tell, we only retrieve DNS addresses here, and we only want the DNS servers associated with usable interfaces. ------------- PR: https://git.openjdk.org/jdk/pull/12593
