On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce <d...@openjdk.org> wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing >> list. > > Rich DiCroce has updated the pull request incrementally with two additional > commits since the last revision: > > - Forgot to add file > - Resolve review comments src/java.base/windows/native/libnet/NetworkInterface.c line 288: > 286: } > 287: > 288: static jobject createNetworkInterfaceForSingleRowWithTables( I think it would be helpful for future maintainers if there was a comment on each of static functions to make it clear what they do. src/java.base/windows/native/libnet/NetworkInterface.h line 39: > 37: struct _netaddr *Next; > 38: } netaddr; > 39: Can NetworkInterface.h be dropped, and netaddr moved to NetworkInterface.c? ------------- PR: https://git.openjdk.org/jdk/pull/12593
