On Wed, 1 Mar 2023 22:38:32 GMT, Paul Sandoz <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl
>> - abstract implementations of RefEntry, RefsEntry and NamedEntry renamed to
>> AbstractRefEntry, AbstractRefsEntry and AbstractNamedEntry
>> - renamed ConcreteBootstrapMethodEntry to BootstrapMethodEntryImpl
>> - ConcreteEntry renamed to AbstractPoolEntry
>
> src/java.base/share/classes/jdk/internal/classfile/impl/SplitConstantPool.java
> line 167:
>
>> 165: buf.patchInt(pos + 2, 4, attrLen - 6);
>> 166: buf.patchInt(pos + 6, 2, bsmSize);
>> 167: return true;
>
> The if and else branch return true, factor out at the end of the method?
fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/impl/SplitConstantPool.java
> line 339:
>
>> 337: }
>> 338:
>> 339: private<T> AbstractPoolEntry.Utf8EntryImpl tryFindUtf8(int hash,
>> String target) {
>
> Unused type variable `T`
fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/impl/SplitConstantPool.java
> line 488:
>
>> 486: return methodHandleEntry(refKind, reference);
>> 487: }
>> 488: return internalAdd(new
>> AbstractPoolEntry.MethodHandleEntryImpl(this, size, hash, refKind,
>> (AbstractPoolEntry.AbstractMemberRefEntry) reference), hash);
>
> Break the long line (same for two following methods).
fixed, thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
