On Thu, 2 Mar 2023 18:31:54 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I >> thought I'd get out for the review the next phase of the FDLIBM port: >> removing the FDLIBM C sources from the repo. >> >> A repo with the changes for JDK-8302027 and this PR successful build on the >> default set of platform and successfully run tier 1 tests, which includes >> tests of the math library. >> >> There are a few remaining references to the case-independent string "fdlibm" >> in the make directory and HotSpot sources. HotSpot contains a partial fork >> for FDLIBM (a tine of FDLIBM?) to use for intrinsics. The remaining make >> machinery contains logic to determine what set of gcc options can be used >> for the compile. >> >> The intention of this change is to remove use of FDLIBM for the core >> libraries. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback and add description of transliteration process. src/hotspot/share/runtime/sharedRuntimeTrig.cpp line 34: > 32: // StrictMath. Avoiding the indirect call through function > 33: // pointer out to libjava.so in SharedRuntime speeds these routines up > 34: // by roughly 15% on multiple architectures. These functions will no longer be in libjava so maybe the "Avoiding the indirect call ..." sentence should be dropped too. ------------- PR: https://git.openjdk.org/jdk/pull/12821
