On Fri, 3 Mar 2023 01:02:40 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:

> Hotspot changes are okay but I'm a bit confused about what the hotspot code 
> will now be used for?

I'm not 100% positive if the current __kernel_rem_pio2 code would be in use. 
IIRC, back when we used the fsin/fcos instructions to intrinsify sin/cos on the 
x87 FPU, to meet Java semantics we needed to do argument reduction into the 
range supported by fsin/fcos. Perhaps  __kernel_rem_pio2 is a hold-over from 
that time? I believe my recent sin/cos algorithms for instrincs wouldn't need 
to use these pathways.

-------------

PR: https://git.openjdk.org/jdk/pull/12821

Reply via email to