On Fri, 3 Mar 2023 04:04:25 GMT, Kim Barrett <[email protected]> wrote:
> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
A few initial comments while I try to digest this.
I don't use these particular debugging mechanism, neither Debugger nor
BREAKPOINT, but it seems potentially problematic to me that the removed
BREAKPOINTs happened after the error was reported, and IIUC the new mechanism
will activate before the error is reported.
Thanks.
make/hotspot/lib/CompileJvm.gmk line 103:
> 101: DISABLED_WARNINGS_xlc := tautological-compare shift-negative-value
> 102:
> 103: DISABLED_WARNINGS_microsoft := 4624 4244 4291 4146 4127 4722
It is annoying that we don't document what these warnings are. :(
src/hotspot/share/utilities/debug.cpp line 85:
> 83: if (is_enabled()) {
> 84: fatal("Multiple Debugging contexts");
> 85: }
This seems too restrictive as you could hit different DebuggingContexts in
different threads. ??
src/hotspot/share/utilities/debug.cpp line 290:
> 288: private:
> 289: ResourceMark _rm;
> 290: DebuggingContext _debugging;
Why a different initialization syntax here?
-------------
PR: https://git.openjdk.org/jdk/pull/12845
