On Sat, 4 Mar 2023 11:23:58 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revision: > > make Debugging::_enabled a nesting counter Seems fine. I'll test drive with the debug commands next time I need to use them but this is similar to to the changes I have in my private repos. Thanks for keeping this functionality. src/hotspot/share/utilities/debug.hpp line 108: > 106: // because we need a fallback when we don't have any mechanism for > detecting > 107: // constant evaluation. > 108: #if defined(TARGET_COMPILER_gcc) || defined(TARGET_COMPILER_xlc) All this seems like it should go in COMPILER_HEADER(globalDefinitions.hpp) but since globalDefinitions.hpp includes debug.hpp, you can't do this. Can we file an RFE to clean this up (if possible)? ------------- Marked as reviewed by coleenp (Reviewer). PR: https://git.openjdk.org/jdk/pull/12845
