On Thu, 9 Mar 2023 02:51:24 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Has this totally killed of BSD support on the JDK side? I thought building
> non-macOS BSD was still viable, but perhaps not - certainly not after this
> change.
I haven't found any use of BSD and I don't think the build supports a BSD build.
> src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 48:
>
>> 46: * For example,
>> 47: * {@snippet lang = "java":
>> 48: * if (OperatingSystem.current() == Windows) {
>
> Doesn't `Windows` need to be prefixed with `OperatingSystem` here? Ditto for
> dispatch example following.
Yes, either a static import or a qualified name is needed.
(This is internal javadoc).
> src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 105:
>
>> 103: */
>> 104: @ForceInline
>> 105: public static boolean isMac() {
>
> suggestion: isMacOS
As above, sticking to a generic term can make this a bit less sensitive to
branding changes.
-------------
PR: https://git.openjdk.org/jdk/pull/12931
