On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - Simple API to replace adhoc comparisons with `os.name`
> - Clear and consistent use across build, runtime, and JDK modules
>
> The PR includes updates within java.base to use the new API.
Looks good. Some minor nits follow.
src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 261:
> 259:
> 260: /**
> 261: * {@eturn the {@code os.arch} system property}
typo: 'r' is misssing
src/java.base/unix/classes/java/lang/ProcessImpl.java line 106:
> 104: try {
> 105: // Should be value of a LaunchMechanism enum
> 106: LaunchMechanism lm =
> LaunchMechanism.valueOf(s.toUpperCase(Locale.ENGLISH));
I think `Locale.ROOT` is preferred here.
test/jdk/java/foreign/TestUnsupportedLinker.java line 2:
> 1: /*
> 2: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
2022, 2023?
-------------
PR: https://git.openjdk.org/jdk/pull/12931
