On Thu, 9 Mar 2023 17:12:53 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>>> I would argue that we should keep the replacement string matching the make >>> variable its getting the value from. It makes it easier to trace the origin >>> of the value. >> >> Then we can define a new make variable that will also allow it be a >> different value than `OPENJDK_TARGET_OS` if desirable. > > There is no need to define a new variable, there are already too many in the > build and the build and the compiled files should be using the same symbols. IMO the naming should make sense from the perspective of reading the post-processed source file - so the variable should refer to "current" not "target". ------------- PR: https://git.openjdk.org/jdk/pull/12931
