On Tue, 14 Mar 2023 15:49:56 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Proposing accessor methods to Emoji properties defined in [Unicode Technical >> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` >> class. This is per a request from the client group, as well as refining the >> currently existing ad-hoc emoji implementation in regex. A CSR has also been >> drafted, and I would appreciate reviews for it too. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed method descriptions Would it make sense to add something like the following to `GenerateCharacter.propertiesComments`? if ((val & maskEmoji) == maskEmoji) { result.append(", emoji "); } if ((val & maskEmojiPresentation) == maskEmojiPresentation) { result.append(", emojiPresentation "); } if ((val & maskEmojiModifier) == maskEmojiModifier) { result.append(", emojiModifier "); } if ((val & maskEmojiModifierBase) == maskEmojiModifierBase) { result.append(", emojiModifierBase "); } if ((val & maskEmojiComponent) == maskEmojiComponent) { result.append(", emojiComponent "); } if ((val & maskExtendedPictographic) == maskExtendedPictographic) { result.append(", extendedPictographic "); } This updates the comments of the B table to something like this sample: 0x0000, // 34 unassigned, L 0x0440, // 35 unassigned, L, emoji , emojiComponent 0x0000, // 36 unassigned, L ------------- PR: https://git.openjdk.org/jdk/pull/13006
