On Tue, 14 Mar 2023 17:09:54 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed method descriptions > > make/jdk/src/classes/build/tools/generatecharacter/GenerateCharacter.java > line 215: > >> 213: maskEmojiComponent = 0x040000000000L, >> 214: maskExtendedPictographic = 0x080000000000L; >> 215: > > Would be nice the have the '=' aligned in the same column as the ones above, > or at least have the emoji ones align with each other. Thanks. Indentation aligned, and although in production `-string` is used so comments are not emitted, added information for `B` table in `GenerateCharacter.propertiesComments` for consistency. ------------- PR: https://git.openjdk.org/jdk/pull/13006