On Tue, 14 Mar 2023 18:21:33 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >> - Simple API to replace adhoc comparisons with `os.name` >> - Clear and consistent use across build, runtime, and JDK modules >> >> The PR includes updates within java.base to use the new API. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Cover default case in switch on OS. src/java.base/unix/classes/java/lang/ProcessImpl.java line 29: > 27: > 28: import java.lang.ProcessBuilder.Redirect; > 29: import jdk.internal.util.OperatingSystem; Moving this import after `java.*` would be better ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12931#discussion_r1145456690
