On Fri, 24 Mar 2023 11:40:01 GMT, Matthias Baesken <[email protected]> wrote:
> Currently the support for the JVM feature 'dtrace' is not implemented in the > HS codebase on ppc, so we should disable it in the jvm-features make > detection as well. Otherwise we could run into building with dtrace feature > support if e.g. the 'dtrace' tool and related header(s) are available on the > build machine. > > Probably the same is true for the s390x platform, see > https://github.com/openjdk/jdk/blob/0deb648985b018653ccdaf193dc13b3cf21c088a/src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp#L226 > but I only looked a bit more into ppc. make/autoconf/jvm-features.m4 line 252: > 250: AC_MSG_CHECKING([for dtrace tool]) > 251: if test "x$OPENJDK_TARGET_CPU_ARCH" = "xppc"; then > 252: AC_MSG_RESULT([no]) Look at how the block above replies the OS-CPU, to highlight that we don't have this support due to arch. Should do the same here. https://github.com/openjdk/jdk/pull/13173/files#diff-a09b08bcd422d0a8fb32a95ccf85051ac1e69bef2bd420d579f74d8efa286d2fR236 AC_MSG_RESULT([no, $OPENJDK_TARGET_OS-$OPENJDK_TARGET_CPU]) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13173#discussion_r1147485427
