On Fri, 24 Mar 2023 12:20:32 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> Currently the support for the JVM feature 'dtrace' is not implemented in the >> HS codebase on ppc, so we should disable it in the jvm-features make >> detection as well. Otherwise we could run into building with dtrace feature >> support if e.g. the 'dtrace' tool and related header(s) are available on the >> build machine. >> >> Probably the same is true for the s390x platform, see >> https://github.com/openjdk/jdk/blob/0deb648985b018653ccdaf193dc13b3cf21c088a/src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp#L226 >> but I only looked a bit more into ppc. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Adjust output for dtrace checking Looks good to me. Will you take care of s390x in a separate PR? Or will @offamitkumar handle it? ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13173#pullrequestreview-1358512510
