On Fri, 24 Mar 2023 17:06:45 GMT, Roger Riggs <rri...@openjdk.org> wrote:

>> Improvements to support OS specific customization for JDK internal use:
>>  - To select values and code; allowing elimination of unused code and values
>>  - Optionally evaluated by build processes, compilation, or archiving (i.e. 
>> CDS)
>>  - Simple API to replace adhoc comparisons with `os.name`
>>  - Clear and consistent use across build, runtime, and JDK modules
>>  
>> The PR includes updates within java.base to use the new API.
>
> Roger Riggs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   clarify Linux

src/java.base/unix/classes/java/lang/ProcessImpl.java line 95:

> 93:     /**
> 94:      * {@return the default or requested launch mechanism}
> 95:      * @throw Error if the requested launch mechanism is not found or 
> valid

Shouldn't it be `@throws` instead of `@throw` ?

src/java.base/unix/classes/java/lang/ProcessImpl.java line 97:

> 95:      * @throw Error if the requested launch mechanism is not found or 
> valid
> 96:      */
> 97:     @SuppressWarnings("removal")

What is deprecated for removal in this method?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12931#discussion_r1149036771
PR Review Comment: https://git.openjdk.org/jdk/pull/12931#discussion_r1149038057

Reply via email to