On Mon, 27 Mar 2023 16:00:00 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >> - Simple API to replace adhoc comparisons with `os.name` >> - Clear and consistent use across build, runtime, and JDK modules >> >> The PR includes updates within java.base to use the new API. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Correct javadoc throws keyword Changes requested by aturbanov (Committer). src/java.base/unix/classes/java/lang/ProcessImpl.java line 97: > 95: * @throws Error if the requested launch mechanism is not found or > valid > 96: */ > 97: @SuppressWarnings("removal") So, we can remove it Suggestion: ------------- PR Review: https://git.openjdk.org/jdk/pull/12931#pullrequestreview-1359391095 PR Review Comment: https://git.openjdk.org/jdk/pull/12931#discussion_r1149469843