On Thu, 6 Apr 2023 07:40:50 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> src/java.base/share/classes/jdk/internal/util/Architecture.java line 85:
>
>> 83: */
>> 84: @ForceInline
>> 85: public static boolean isRISCV64() {
>
> Are all the "isers" necessary to provide constant code folding or is the samt
> thing achievable via expressions like `(Architecture.current() ==
> Architecture.X)` ?
`Architecture.current()` requires the `Architecture.archValues` array to be
annotated with `@jdk.internal.vm.annotation.Stable` for it to be constant
foldable by the JIT.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1159428913
