On Thu, 6 Apr 2023 18:44:02 GMT, Alan Bateman <[email protected]> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to Foreign API to avoid class with another PR
>> Rename S390X to S390, representing just the s390 architecture
>> Removed ARM and IA64 enum values; they are unused; they can be added later
>> if needed
>
> src/jdk.attach/windows/classes/sun/tools/attach/AttachProviderImpl.java line
> 51:
>
>> 49: !Architecture.isAARCH64()) {
>> 50: throw new RuntimeException(
>> 51: "This provider is not supported on this processor
>> architecture: " + Architecture.current());
>
> Could this constructor be changed to be a no-op? The check for Windows 9 and
> Windows Me dates back to JDK 6 and is no longer needed. The os.arch check
> also dates from JDK 6 when the attach provider didn't work on IA64 The only
> Windows builds now are windows-x86, windows-x64, windows-aarch64 so I assume
> this check can go away.
Removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1160154277
