On Thu, 6 Apr 2023 10:54:18 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> API changes for the FFM API (third preview) >> >> Specdiff: >> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html >> >> Javadoc: >> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - 8305369: Issues in zero-length memory segment javadoc section > - 8305087: MemoryLayout API checks should be more eager Hotspot changes look good. src/hotspot/share/prims/jvm.cpp line 3473: > 3471: > 3472: JVM_LEAF(jboolean, JVM_IsForeignLinkerSupported(void)) > 3473: return ForeignGlobals::has_port() ? JNI_TRUE : JNI_FALSE; On naming: I find `has_port()` confusing. Why don't you simply call VM counterpart `is_foreign_linker_supported`? Alternative ideas: `is_supported()`, `has_native_support()`. ------------- Marked as reviewed by vlivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13079#pullrequestreview-1379816547 PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1163158810
