On Thu, 13 Apr 2023 06:36:51 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> API changes for the FFM API (third preview) >> >> ### Specdiff >> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html >> >> ### Javadoc >> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html >> >> ### Tests >> >> - [X] Tier1 >> - [X] Tier2 >> - [ ] Tier3 >> - [ ] Tier4 >> - [ ] Tier5 >> - [ ] Tier6 > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge pull request #3 from JornVernee/IsForeignLinkerSupported > > rename has_port > - rename has_port test/jdk/java/foreign/TestByteBuffer.java line 335: > 333: assertEquals(byteBuffer.isReadOnly(), > segment.isReadOnly()); > 334: assertTrue(byteBuffer.isDirect()); > 335: } catch(IOException e) { nit Suggestion: } catch (IOException e) { ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1171075598