On Thu, 27 Apr 2023 17:57:05 GMT, Antonios Printezis <to...@openjdk.org> wrote:

> Fix is to exclude hsdis when building the buildjdk.

This looks like it should work, but I would like to avoid sprinkling any more 
CREATING_BUILDJDK conditionals throughout the build than absolutely necessary. 
I think it would be better to just override `HSDIS_BACKEND` and 
`ENABLE_HSDIS_BUNDLING` in `buildjdk-spec.gmk.in` with a comment that hsdis 
should never be enabled in the buildjdk. I haven't tested it though so I may be 
missing something.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13697#pullrequestreview-1404637087

Reply via email to