On Thu, 27 Apr 2023 20:08:29 GMT, Antonios Printezis <to...@openjdk.org> wrote:
>> Fix is to exclude hsdis when building the buildjdk. > > Antonios Printezis has updated the pull request incrementally with one > additional commit since the last revision: > > changes based on Erik's feedback make/autoconf/buildjdk-spec.gmk.in line 109: > 107: # hsdis is not needed > 108: override HSDIS_BACKEND := none > 109: override ENABLE_HSDIS_BUNDLING := false You shouldn't need the `override` keyword. That is only needed when the value of the variables is set on the make command line. In this case we are simply overriding the values from the main `spec.gmk`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13697#discussion_r1179652542
