On Fri, 26 May 2023 18:01:51 GMT, Gerard Ziemski <[email protected]> wrote:
>> We now track the in-progress and completed states of VM creation and only
>> return a VM from JNI_GetCreatedJavaVMs when there is a fully initialized VM.
>>
>> Testing:
>> - new regression test
>> - tiers 1-3 (sanity)
>>
>> Thanks
>
> test/hotspot/jtreg/runtime/jni/getCreatedJavaVMs/TestGetCreatedJavaVMs.java
> line 27:
>
>> 25: * @test
>> 26: * @library /test/lib
>> 27: * @requires os.family == "Linux"
>
> Why is it Linux only?
>
> Does `ProcessTools.createNativeTestProcessBuilder("GetCreatedJavaVMs");` only
> work on Linux?
>
> Filed https://bugs.openjdk.org/browse/CODETOOLS-7903477 to have it
> implemented on macOS.
It was Linux only primarily because I copied another test. It should work on
any platform that uses pthreads - so not Windows. I can expand the makefile
logic to build the test code on all platforms.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14139#discussion_r1208772314
