On Fri, 26 May 2023 17:50:58 GMT, Gerard Ziemski <[email protected]> wrote:

>> David Holmes has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Enable the test on all Posix platforms
>
> Looks fine to me.
> 
> I have one question though: why wouldn't it be enough to move `vm_created = 
> 1` from where we had it before, down to where we now have `vm_created = 
> COMPLETE` ?
> 
> I'm not 100% sure why we need the intermediate step `IN_PROGRESS`

Thanks for looking at this @gerard-ziemski . The test now runs on all 
non-Windows platforms.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14139#issuecomment-1566437051

Reply via email to