On Mon, 26 Jun 2023 18:31:06 GMT, Jens Lidestrom <[email protected]> wrote:
>> Please review this cleanup PR to normalize names of identifiers which are
>> Java variables/fields or tokens in text files. Those names either contain a
>> pronoun that is very rarely used in code, or seem like they contain such a
>> pronoun, which, in fact, they don't. Either way, the goal is to improve
>> readability and clarity.
>>
>> Also, this PR fixes a few related typos.
>
> make/data/charsetmapping/charsets line 149:
>
>> 147: package sun.nio.cs
>> 148: type sbcs
>> 149: histname ISO8859_2
>
> Should this column be re-aligned with the longer name?
I thought about it before publishing the PR. I decided not to re-align anything
because (i) the change would be bigger and (ii) the fact that there was already
a property that is similarly misaligned; search for:
internal true
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14653#discussion_r1242617579
