On Mon, 26 Jun 2023 18:44:42 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> make/data/charsetmapping/charsets line 149: >> >>> 147: package sun.nio.cs >>> 148: type sbcs >>> 149: histname ISO8859_2 >> >> Should this column be re-aligned with the longer name? > > I thought about it before publishing the PR. I decided not to re-align > anything because (i) the change would be bigger and (ii) the fact that there > was already a property that is similarly misaligned; search for: > > internal true If you are concerned with functionality rather than looks, then I can tell you this: 1. The build succeeds and tier1 tests pass. 2. The code that parses that file expect one or more whitespace characters as a separator: String[] tokens = line.split("\\s+"); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14653#discussion_r1242629052