On Tue, 18 Jul 2023 07:58:58 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS issue this option is currently a no-op and has been >> there only for backward compatible since even Java 8 days. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > include -debug (alias) option in the deprecated log message src/java.base/share/classes/sun/launcher/resources/launcher.properties line 137: > 135: \ -Xcheck:jni perform additional checks for JNI functions\n\ > 136: \ -Xcomp forces compilation of methods on first > invocation\n\ > 137: \ -Xdebug deprecated and may be removed in a future > release.\n\ This drops "does nothing" so no longer clear that the option doesn't do anything. It could be changed to "does nothing; deprecated for removal in a future release". Alternatively maybe it would be better to just remove it from the -X output. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14918#discussion_r1266609817
