On Wed, 19 Jul 2023 07:05:51 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for 
>> removal the  `-Xdebug` option and `-debug` option of the `java` command? 
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been 
>> there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Alan's suggestion - report -debug usage as a warning right in the java.c 
> code

Adding one of my previous comments again, because it's not easily visible among 
the bot generated comments in the GitHub UI:

> I would like inputs on the 
> test/hotspot/jtreg/runtime/6294277/SourceDebugExtension.java test. That test 
> launches java passing it the -Xdebug option and was introduced as part of 
> https://bugs.openjdk.org/browse/JDK-6294277. -Xdebug has been a no-op for 
> many releases now. Is this test still relevant and if not, should I go ahead 
> and remove it as part of this change?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1641534305

Reply via email to