On Fri, 4 Aug 2023 12:35:20 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid the
> flag there? flags-other.m4 : the comment 'on AIX ...' is just stating the
> obvious; maybe it should better mention that without -X64 we only process
> 32bit objects ('Processes only 32-bit object files' says the manpage , and
> this is the default on AIX) ; or avoid the comment altogether ?
I didn't see these nm calls. I focused on the AIX specific only. Thanks for
mentioning this. When are static libraries and mapfiles used? In addition I'm
wondering how the nm call with the -m option in the else condition will work.
This option is not known by all nm implementations, as I know.
I add the NMFLAGS to the missing nm calls, also for other target OS and
improved the comment.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15150#issuecomment-1665727411
