On Tue, 8 Aug 2023 20:50:11 GMT, Christoph Langer <clan...@openjdk.org> wrote:
> > > Looks good overall. I suggest to remove the BUILD_NM variable in this PR > > > as well. We should then wait with a final review until some folks from > > > the Oracle build team are back. > > > > > > What is the motivation for removing BUILD_NM? I believe that would break > > cross compilation. > > Hm, I guess I didn't/don't really understand how it is used. But alright then > 😄 All the `BUILD_` prefixed variables replace the main variables when compiling a "BUILDJDK" during a cross compilation build. This happens in `make/autoconf/buildjdk-spec.gmk.in`. For completeness we should add a BUILD_NMFLAGS, but I think that can wait for now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15150#issuecomment-1671209008
