On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil <jkratoch...@openjdk.org> wrote:
>> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust compatibility with FILE_MACRO_CFLAGS. make/common/NativeCompilation.gmk line 228: > 226: # ignore such dependencies. > 227: ifneq ($(CCACHE), ) > 228: NEED_FIX_DEPS_FILE = 1 If the ccache case needs both of these macros, then the variable name should reflect that better. Maybe `REWRITE_PATHS_RELATIVE`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15080#discussion_r1287435960
