On Wed, 9 Aug 2023 02:35:53 GMT, Jan Kratochvil <jkratoch...@openjdk.org> wrote:
>> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Rename NEED_FIX_DEPS_FILE to REWRITE_PATHS_RELATIVE > - suggested by Erik Joelsson. make/common/NativeCompilation.gmk line 231: > 229: endif > 230: > 231: ifdef REWRITE_PATHS_RELATIVE We generally try to protect the makefiles from misbehaving due to environment variables being set with unexpected values. We also prefer `true`/`false` for boolean values. In this case it would be better to initialize REWRITE_PATHS_RELATIVE to `false`, set it to `true` in the conditionals and check equals here. ifeq ($(REWRITE_PATHS_RELATIVE), true) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15080#discussion_r1288366677
