I agree with Thomas and Mark, I too don't see this change favourably. This change would affect current build environments and setups, introduce unforeseen bugs and as Thomas mentioned the backporting work itself. Even changes due to JEP 347 did potentially make backporting more difficult, however it standardised on a fixed and broadly available version of gcc, and in this case C++17 would mean being forced to update.
The right place for this sort of changes is a JEP and it needs to be widely discussed with porters and the updates maintainers before even going into mainline. In your case the JEP was rejected, I would accept that because this is an invasive change that may not bring relevant benefits, but at the very least the right thing to do would be to write a better proposal and make a [very] compelling case in the JEP on why we may want to update now, with the prerequisite of a discussion on this proposal and its benefits on the main development list to make sure many more eyes did see this. Eventually there will be a time where we can and maybe should consider c++17 (or later), I don't think this is now however. Cheers, Mario On Thu, Aug 17, 2023 at 8:04 AM Thomas Stuefe <stu...@openjdk.org> wrote: > > On Mon, 24 Jul 2023 01:41:16 GMT, Julian Waters <jwat...@openjdk.org> wrote: > > > Implementation of [JEP draft: Compile the JDK as > > C++17](https://bugs.openjdk.org/browse/JDK-8310260) > > I disagree with this change. This should be discussed more broadly before > trying to get a PR in. The associated JEP has been closed by Mark. Just a "oh > well, then I'm doing it without JEP" is not the right way. > > Before agreeing to this, I would like to know what actual changes have been > planned, and see them weighted against the cost. The cost, as I have stated > before, are reviewer churn, implementation risk, and increased cost of > downporting patches to older JDK versions. > > ------------- > > PR Comment: https://git.openjdk.org/jdk/pull/14988#issuecomment-1681660826 > -- Mario Torre Manager, Software Engineering, Red Hat OpenJDK, Java Champion https://keybase.io/neugens 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 Mastodon: https://mastodon.social/@MarioTorre Red Hat GmbH, Registered seat: Werner von Siemens Ring 12, D-85630 Grasbrunn, Germany Commercial register: Amtsgericht Muenchen/Munich, HRB 153243, Managing Directors: Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross
